-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update useOnMountEffect to pass isMountedRef to callback #2413
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: fcfcc3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (6baf35d) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2413" Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2413 |
Size Change: +27 B (+0.03%) Total Size: 96.4 kB
ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-iozczqmdjl.chromatic.com/ Chromatic results:
|
Summary:
Without this, consumers of useOnMountEffect have to keep track of whether the hosting component is mounted or not when running async code within the effect.
Issue: None
Test plan: