-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update interactive graph question data from the latest snapshot #1757
Draft
benchristel
wants to merge
2
commits into
main
Choose a base branch
from
benc/update-data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (6a63ab9) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1757 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1757 |
Size Change: 0 B Total Size: 866 kB ℹ️ View Unchanged
|
benchristel
force-pushed
the
benc/update-data
branch
from
October 17, 2024 00:03
48005f0
to
6a63ab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's come to our attention that some interactive graph angle questions
are blocking learners because the angle cannot be moved into the correct position.
We missed these questions during testing because we were only testing graphs in
a somewhat out-of-date content snapshot.
This commit updates our test data so we can identify and fix the broken questions.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2540
Test plan:
yarn dev
Visit
http://localhost:5173/#flipbook
Run this shell command and paste into the flipbook input:
You should see some interactive graphs!