This repository has been archived by the owner on Aug 6, 2018. It is now read-only.
Image cropping support #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go to a specific thumb and type in some fancy-smancy JSON
to define your scaled versions.
Then edit an entry with a media selected and boom hit "Crop"
to get a scaler view where you can select 1 crop for each
scale version you set up.
This adds some new semantics to templating mediaflow fields as well:
```twig
{{entry.image.url('thumb')}}
```
Loads the `thumb` version from this field settings example:
```js
{"thumb":[100,100]}
```
…efore it is loaded
…ave a specific crop set
|
Hi Raymond! Any reason why this wasn't merged to master before you left? |
|
Needed more real world testing, I think RR experienced some bugs. |
|
Sure did - we could not get the crop to show in a template in our environment. We are open and ready for testing @beery |
|
I guess the problem relates to this issue: #9, which I have commented on now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds image cropping support:
Crops can be set up as a JSON:
And later accessed in templates: