Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.6: Upgrade packages, implement metrics.metricsAddress and containerPorts in Helm chart, refactor release process #22

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

m8rmclaren
Copy link
Contributor

@m8rmclaren m8rmclaren commented Dec 21, 2023

v1.0.6

Features

  • feat(helm): Rename secureMetrics to metrics and add metrics.secure and metrics.metricsAddress as configuration values. This way, Prometheus can scrape the controller manager metrics without the secure metrics proxy.
  • feat(helm): Add configuration element in Helm chart default values file to configure container ports on the controller manager container.

Fixes

  • fix(deps): Update golang.org/x/net to v0.19.0
  • fix(dockerfile): Upgrade builder image to golang:1.20 to address CVE-2023-38408

@m8rmclaren m8rmclaren self-assigned this Dec 21, 2023
@m8rmclaren
Copy link
Contributor Author

Image vulnerability analysis:
image

Test results:
image

@m8rmclaren
Copy link
Contributor Author

Pod state with the following Helm install command:

helm package deploy/charts/command-cert-manager-issuer --app-version=1.0.6 --version=1.0.6

# Install the locally packaged Helm chart and point it to the local image
helm install command-cert-manager-issuer command-cert-manager-issuer-1.0.6.tgz \
    --namespace command-issuer-system \
    --create-namespace \
    --set image.pullPolicy=Never \
    --set metrics.metricsAddress=:8080
image image

Pod state demonstrates successful configuration of manager container arguments to configure metrics server address, and container logs display accepted configuration.

Copy link
Contributor

@fiddlermikey fiddlermikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from support/delivery

@fiddlermikey fiddlermikey merged commit bfae5f7 into v1.0.6 Dec 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants