Skip to content

Commit

Permalink
Merge pull request #18 from Keyfactor/localdev
Browse files Browse the repository at this point in the history
fix(makefile): Bug naming convention in deploy-local target
  • Loading branch information
m8rmclaren authored Oct 30, 2023
2 parents 8d16335 + a0812c5 commit 037e9d9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
## Features
* feat(signer): Signer recognizes `metadata.command-issuer.keyfactor.com/<metadata-field-name>: <metadata-value>` annotations on the CertificateRequest resource and uses them to populate certificate metadata in Command.
* feat(release): Container build and release now uses GitHub Actions.

## Fixes
* fix(helm): CRDs now correspond to correct values for the `command-issuer`.
* fix(helm): Signer Helm Chart now includes a `secureMetrics` value to enable/disable sidecar RBAC container for further protection of the `/metrics` endpoint.
* fix(signer): Signer now returns CA chain bytes instead of appending to the leaf certificate.
Expand Down
5 changes: 2 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ DOCKER_REGISTRY ?= ""
DOCKER_IMAGE_NAME ?= ""
# Image URL to use all building/pushing image targets
IMG ?= ${DOCKER_REGISTRY}/${DOCKER_IMAGE_NAME}:${VERSION}
#IMG ?= command-issuer-dev:latest

# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary.
ENVTEST_K8S_VERSION = 1.26.0
Expand Down Expand Up @@ -131,8 +130,8 @@ deploy: manifests kustomize ## Deploy controller to the K8s cluster specified in
# Then, install it into the K8s cluster
.PHONY: deploy-local
deploy-local: manifests kustomize ## Build docker image with the manager.
docker build -t ejbca-issuer-dev:latest -f Dockerfile .
cd config/manager && $(KUSTOMIZE) edit set image controller=ejbca-issuer-dev:latest
docker build -t command-issuer-dev:latest -f Dockerfile .
cd config/manager && $(KUSTOMIZE) edit set image controller=command-issuer-dev:latest
$(KUSTOMIZE) build config/default | kubectl apply -f -

.PHONY: undeploy
Expand Down

0 comments on commit 037e9d9

Please sign in to comment.