Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.github): default dir configuration from release workflow #400

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

KeisukeYamashita
Copy link
Owner

@KeisukeYamashita KeisukeYamashita commented Dec 3, 2024

Why

Solves: #398
As the title says, the release CI is failing.
Now we use Cargo workspace, I'll remove the default directory configuration which used to point to cli/.

Summary by CodeRabbit

  • Chores
    • Simplified workflow by removing the default working directory specification.
    • Maintained existing job structure and permissions for build, publish, and deployment processes.

@KeisukeYamashita KeisukeYamashita self-assigned this Dec 3, 2024
Copy link

coderabbitai bot commented Dec 3, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the .github/workflows/release.yaml file by removing the defaults section, which defined a common working directory for jobs. This change allows each job to specify its own working directory independently. The existing job structure remains intact, with jobs for building, publishing, and deploying the application. The permissions section is unchanged, ensuring consistent access levels across the workflow.

Changes

File Path Change Summary
.github/workflows/release.yaml Removed defaults section; jobs now specify their own working directories; no changes to permissions.

Possibly related PRs

Poem

In the workflow's dance, we twirl and spin,
Removing defaults, let the jobs begin!
Each job now stands, proud and free,
Building and publishing, as happy as can be!
With Rust and Docker, we leap with glee,
A streamlined process, oh what a sight to see! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1e7622d and 6c6da79.

📒 Files selected for processing (1)
  • .github/workflows/release.yaml (0 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KeisukeYamashita KeisukeYamashita linked an issue Dec 3, 2024 that may be closed by this pull request
@KeisukeYamashita KeisukeYamashita force-pushed the fix-release-workflow-schema-binary branch from 89f9ffe to 6c6da79 Compare December 3, 2024 10:24
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
the runner of "actions-rs/toolchain@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]

- uses: actions-rs/toolchain@v1

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
the runner of "actions-rs/toolchain@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]

- uses: actions-rs/toolchain@v1

@KeisukeYamashita KeisukeYamashita changed the title fix(.github): release workflow failing to build binary and schema fix(.github): remove default dir configuration from release workflow Dec 3, 2024
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
the runner of "actions-rs/toolchain@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]

- uses: actions-rs/toolchain@v1

@KeisukeYamashita KeisukeYamashita changed the title fix(.github): remove default dir configuration from release workflow fix(.github): default dir configuration from release workflow Dec 3, 2024
@KeisukeYamashita KeisukeYamashita marked this pull request as ready for review December 3, 2024 10:26
@KeisukeYamashita KeisukeYamashita merged commit 1ebdd8b into main Dec 3, 2024
34 of 35 checks passed
@KeisukeYamashita KeisukeYamashita deleted the fix-release-workflow-schema-binary branch December 3, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v0.2.0
1 participant