Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add result type which allows to do response modifications #439

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

Kaliumhexacyanoferrat
Copy link
Owner

No description provided.

@Kaliumhexacyanoferrat Kaliumhexacyanoferrat self-assigned this Jan 3, 2024
@jacobalbano jacobalbano marked this pull request as ready for review January 3, 2024 18:07
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API looks good to me; it's essentially what I've already put together on my own, but with the benefit that it handles the response building implicitly under the hood, and since all it does is modify a default response, it removes a lot of the busywork that's necessary when building a response manually. Very nice.

jacobalbano
jacobalbano previously approved these changes Jan 3, 2024
Copy link
Collaborator

@jacobalbano jacobalbano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me; the only comment I have is about the visibility of IResult, but if that's by design then I have no complaints.

@Kaliumhexacyanoferrat
Copy link
Owner Author

@jacobalbano : Thank you very much for the review, I moved the Result<T> into the reflection module to hide the implementation details.

@Kaliumhexacyanoferrat Kaliumhexacyanoferrat merged commit 1e19149 into master Jan 4, 2024
1 check passed
@Kaliumhexacyanoferrat Kaliumhexacyanoferrat deleted the result branch January 4, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slightly adjust responses without the need of building a response
2 participants