Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a function to compute the minimum of Jacobian (displacement) #200

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

keiyamamo
Copy link
Collaborator

This PR adds a function to compute the minimum of Jacobian, which could be used to measure the quality of the mesh.
This can be used to help investigate the reason for divergence.

Ref. Fig.6 in this paper: https://www.ljll.fr/~frey/papers/meshing/Wick%20T.,%20Fluid-structure%20interactions%20using%20different%20mesh%20motion%20techniques.pdf

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.36%. Comparing base (8193818) to head (6eb2bcd).

Files with missing lines Patch % Lines
src/vasp/automatedPostprocessing/log_plotter.py 63.63% 4 Missing ⚠️
src/vasp/simulations/avf.py 0.00% 2 Missing ⚠️
src/vasp/simulations/simulation_common.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   81.42%   81.36%   -0.06%     
==========================================
  Files          32       32              
  Lines        3859     3886      +27     
==========================================
+ Hits         3142     3162      +20     
- Misses        717      724       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@keiyamamo keiyamamo marked this pull request as ready for review November 22, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants