Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use tcp server based track matcher #1386

Merged
merged 17 commits into from
Apr 11, 2024
Merged

Conversation

@KRTirtho KRTirtho changed the base branch from master to dev April 11, 2024 09:33
@KRTirtho
Copy link
Owner Author

KRTirtho commented Apr 11, 2024

@owencz1998 @meenbeese @karniv00l @MerkomassDev
It'd be nice if you guys can test out the playback and check if it's meeting expectations.
Builds are available in the nightly channel

@MerkomassDev
Copy link
Contributor

MerkomassDev commented Apr 11, 2024

So far I managed to play multiple (3 but I could go further) playlists at once
Screenshot_2024-04-11-11-55-14-337-edit_oss.krtirtho.spotube.nightly.jpg

When you want to switch playlists, you're only able to switch to a playlist you haven't played yet as switching doesn't "turn off the currently playing playlist status"

Screenshot_2024-04-11-12-00-19-331_oss.krtirtho.spotube.nightly.jpg

You can't even switch to an individual song from an already played playlist

And for the playback, it performs about as expected so far, haven't got stuck on a song yet

@MerkomassDev
Copy link
Contributor

Testing it further and found out, that I can play all songs from the first played playlist and also songs that are shared with the first played playlist

Playlists which I haven't played yet can be played but I can't switch to them back after playing another one

@MerkomassDev
Copy link
Contributor

MerkomassDev commented Apr 11, 2024

Whenever there's not a song playing, the current playing song thing is empty (it shouldn't display at all)

Screenshot_2024-04-11-12-24-17-304-edit_oss.krtirtho.spotube.nightly.jpg

@KRTirtho
Copy link
Owner Author

Thanks @MerkomassDev for mentioning the issues. I faced the last one but forgot to add a fix 😅

@KRTirtho
Copy link
Owner Author

I fixed all the issue you faced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment