Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lcm_event_destroy (not used yet) #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add lcm_event_destroy (not used yet) #63

wants to merge 1 commit into from

Conversation

dehann
Copy link
Member

@dehann dehann commented May 5, 2019

related to #62 but not a complete fix yet

related to #62 but not a complete fix yet
@codecov-io
Copy link

codecov-io commented May 5, 2019

Codecov Report

Merging #63 into master will decrease coverage by 0.26%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   80.59%   80.32%   -0.27%     
==========================================
  Files           5        5              
  Lines         304      305       +1     
==========================================
  Hits          245      245              
- Misses         59       60       +1
Impacted Files Coverage Δ
src/readlog.jl 93.1% <0%> (-3.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a313d94...e30e44b. Read the comment docs.

@rdeits
Copy link
Collaborator

rdeits commented May 8, 2019

Can we add this to the LCMLog tests?

@dehann
Copy link
Member Author

dehann commented May 8, 2019

Good idea, thanks -- I will do that. Don't merge yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants