-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROCm support (AMDGPU) #572
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
7a577a7
Add ROCm (AMDGPU) support
luraess 3dd77fa
Fix tests
luraess cc46cde
Fix tests
luraess b9d5811
Fix tests
luraess 24c4f48
Update doc
luraess 4782cdf
Add doc update
luraess 9545aa8
Merge branch 'JuliaParallel:master' into lr/rocmaware-dev
luraess ef153a2
Update doc with link to rocm scripts
luraess 971a78f
Add cleaner condition
luraess 980ed51
Merge branch 'JuliaParallel:master' into lr/rocmaware-dev
luraess 0fb7f7b
Merge branch 'JuliaParallel:master' into lr/rocmaware-dev
luraess 5e66d2c
Merge branch 'JuliaParallel:master' into lr/rocmaware-dev
luraess 1ebb7dc
Add ROCm tests
luraess 77e9f2c
Update pipeline.yml
luraess dc76404
Update buildkite ROCm MPI launch params
luraess 79006dd
Merge branch 'JuliaParallel:master' into lr/rocmaware-dev
luraess bb53453
Uncomment failing tests
luraess bd7d403
Update CI MPI wrapper
luraess 2b85ac5
Merge branch 'master' of github.com:JuliaParallel/MPI.jl into JuliaPa…
luraess 1bdcee2
Merge branch 'JuliaParallel-master' into lr/rocmaware-dev
luraess 10b454c
Add AMDGPU support to test.
luraess 83cfe02
add buildkite script
simonbyrne fa73ba2
use latest Open MPI
simonbyrne 3426a3a
disable AMDGPU julia 1.6
simonbyrne 27bb633
try UCX 1.13-rc1
simonbyrne 83fe889
Add synchronize
simonbyrne 28edee4
Update test/common.jl
simonbyrne 5fd4180
add more synchronize()
simonbyrne 727c8ea
modify conversion to MPIPtr
simonbyrne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was wrong here @simonbyrne ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A.buf.ptr
is a raw pointer, so the object could be cleaned up by GC. It also loses theoffset
argument required for views.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! TIL