[WIP] better performance in collect_similar
#200
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaqz
reviewed
Oct 23, 2024
| # If the array is chunked, read each chunk and apply the function | ||
| # via broadcasting. | ||
| if DiskArrays.haschunks(input) isa DiskArrays.Chunked | ||
| # TODO: change this if DiskArrays ever supports uneven chunks |
There was a problem hiding this comment.
It does already, but what would need to change?
There was a problem hiding this comment.
This comment can be disregarded I think, at least for now. I need more testing to determine the best approach here.
There was a problem hiding this comment.
For some more context, the approach I had in an earlier iteration of this was that I pre-allocated a single array that would hold the contents read by the diskarray. Then you could readblock! directly into that array allowing us to get away with minimal allocations.
However, this approach seemed to be slower than even the current approach, not sure why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this has a runtime of ~80 microseconds on my test case. Built on top of #198. Feel free to ignore the first two commits.