Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation build fixes #70

Merged
merged 9 commits into from
Jul 8, 2020
Merged

Documentation build fixes #70

merged 9 commits into from
Jul 8, 2020

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented Jul 7, 2020

Following up on #53 (comment) -- documentation should build without errors now. Could enable strict = true actually.

@@ -960,7 +960,7 @@ julia> spin_configurations(c"1s2")

julia> spin_configurations(c"1s2"s)
1-element Array{Configuration{SpinOrbital{Orbital{Int64},Tuple{Int64,HalfIntegers.Half{Int64}}}},1}:
1s²
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's correct as long as #71 is not resolved.

[₁²S]
[₁²Pᵒ, ₃²Dᵒ, ₃⁴Sᵒ]

julia> intermediate_terms(rc"3d2 5g3")
2-element Array{Array{HalfIntegers.Half{Int64},1},1}:
[0, 2, 4]
[3/2, 5/2, 7/2, 9/2, 9/2, 11/2, 13/2, 15/2, 17/2, 21/2]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one this one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

@mortenpi mortenpi merged commit a3d8d71 into master Jul 8, 2020
@mortenpi mortenpi deleted the mp/docfixes branch July 8, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants