Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python version to stabilise launch of mlflow service in CI #28

Merged
merged 12 commits into from
Sep 28, 2023

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Sep 27, 2023

Attempt to address #27

@ablaom ablaom marked this pull request as draft September 27, 2023 22:14
@ablaom
Copy link
Member Author

ablaom commented Sep 27, 2023

@pebeto I tried to launch the service as in MLFlowClient CI, and now the service appears to launch okay, but the test to save an artifact fails to find an artifact.

Can you please help sort out this issue?

@pebeto
Copy link
Member

pebeto commented Sep 28, 2023

@ablaom the MLFlowClient CI configuration for mlflow just test the existence of an artifact, it doesn't retrieve it. To get that working, we need to start mlflow in the same instance running MLJFlow.

I'm going to review it.

@pebeto pebeto self-requested a review September 28, 2023 03:14
@pebeto pebeto self-assigned this Sep 28, 2023
@pebeto pebeto added bug Something isn't working breaking labels Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f7423ca) 97.05% compared to head (4005b79) 97.77%.
Report is 7 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #28      +/-   ##
==========================================
+ Coverage   97.05%   97.77%   +0.71%     
==========================================
  Files           4        4              
  Lines          34       45      +11     
==========================================
+ Hits           33       44      +11     
  Misses          1        1              
Files Coverage Δ
src/MLJFlow.jl 100.00% <ø> (ø)
src/base.jl 100.00% <ø> (ø)
src/service.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pebeto pebeto marked this pull request as ready for review September 28, 2023 03:40
@pebeto pebeto force-pushed the hack-to-launch-mljserver branch from e10a014 to bdb1bc5 Compare September 28, 2023 03:44
@ablaom ablaom changed the title Hack to fix failure of CI to launch mlflow service Fix python version to stabilise launch of mlflow service in CI Sep 28, 2023
@ablaom ablaom closed this Sep 28, 2023
@ablaom ablaom reopened this Sep 28, 2023
@ablaom ablaom merged commit aac96ba into dev Sep 28, 2023
4 checks passed
@pebeto pebeto deleted the hack-to-launch-mljserver branch May 21, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants