-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support in pipelines for Unsupervised
models for which target_in_fit
is true
#984
Conversation
@EssamWisam A review would also be nice, if you have time to study the |
I haven't studied the |
@EssamWisam Can you please confirm this PR resolves your issue with target encoding? |
@ablaom I tried to clone this branch of
Thus, I can only say I believe this would solve the issue but can't be absolutely certain. |
@EssamWisam To help me diagnose, what exactly do you have at line 118 of MLJTransforms/src/target_encoding/interface_mlj.jl ? This will be your overloading of |
I passed an incorrect argument instead of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #984 +/- ##
==========================================
+ Coverage 88.13% 88.21% +0.08%
==========================================
Files 28 28
Lines 2587 2588 +1
==========================================
+ Hits 2280 2283 +3
+ Misses 307 305 -2 ☔ View full report in Codecov by Sentry. |
This PR resolves JuliaAI/MLJ.jl#1134.
An
Unsupervised
model that wants to buy into the new functionality must overloadMLJModelInterface.target_in_fit
to hold true. Here's an example from tests added in this PR.@EssamWisam Can you please confirm this resolves your issue with target encoding?
I have tested this PR with a local run of MLJ's integration tests.