-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CompactPerformanceEvaluation
objects and the option in evaluate!
to construct them
#973
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #973 +/- ##
==========================================
+ Coverage 87.74% 88.13% +0.38%
==========================================
Files 28 28
Lines 2457 2587 +130
==========================================
+ Hits 2156 2280 +124
- Misses 301 307 +6 ☔ View full report in Codecov by Sentry. |
For the second time codecov is getting cancelled. A timeout? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Partly addresses JuliaAI/MLJ.jl#1105, and prepares for JuliaAI/MLJTuning.jl#215.
This PR also drops theThis PR also adjusts the display ofper_fold
part ofPerformanceEvaluation
display. More often than not, the table does not fit with this in it. The display still includes the names of all accessible fields.per_fold
information to mitigate issue with overly wide table.Previously:
After this PR:
To do:
Stack
not broken by addition ofevaluate!
arguments