Minor changes

Jorixon · Nov 11, 2023 · eb46ce4 · eb46ce4
1 parent aa09b3c
commit eb46ce4
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/Images/GameBanana_v1.6.1/CharacterOverview.png b/Images/GameBanana_v1.6.1/CharacterOverview.png
diff --git a/Images/GameBanana_v1.6.1/Settings.png b/Images/GameBanana_v1.6.1/Settings.png
diff --git a/...MI-ModManager.WinUI/Assets/Games/Genshin/Images/Characters/Character_Charlotte_Thumb.webp b/...MI-ModManager.WinUI/Assets/Games/Genshin/Images/Characters/Character_Charlotte_Thumb.webp
diff --git a/src/GIMI-ModManager.WinUI/Services/ActivationService.cs b/src/GIMI-ModManager.WinUI/Services/ActivationService.cs
@@ -166,8 +166,9 @@ await _localSettingsService.SaveSettingAsync(CharacterOverviewSettings.Key,
                 new CharacterOverviewSettings());
     }
 
-
-    private bool _isExiting = false;
+// To allow jasm to save settings before exiting, we need to handle the first close event.
+// Once finished saving the handler calls itself again, but this time it will exit.
+    private bool _isExiting;
 
     private async void OnApplicationExit(object sender, WindowEventArgs args)
     {
@@ -206,6 +207,8 @@ private async void OnApplicationExit(object sender, WindowEventArgs args)
 
         await saveSettingsTask;
         _logger.Debug("JASM shutdown complete.");
+
+        // Call the handler again, this time it will exit.
         await Task.Run(() =>
         {
             _isExiting = true;