Allow injection of PitchDetector into PitchProcessor. #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added constructor with
PitchDetector
parameter toPitchProcessor
, allowing the internal pitch detector used to be specified:This allows the specific parameters of each pitch estimation algorithm to be specified when using the pitch processor.
For example the min and max frequency for AMDF:
The existing constructor is maintained to still allow ease of use by specifying the relevant enum to use the default parameters.