Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify the default values for stateful-chart #4

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

apetrovYa
Copy link
Collaborator

@apetrovYa apetrovYa commented Feb 8, 2024

Pull Request Template

Description

In this PR I simplify the default configuration of the chart. I remove certain defaults that make the reuse of the chart difficult in the future.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chart Version Update

How Has This Been Tested?

The unit tests are updated to reflect the new behavior.

@github-actions github-actions bot added documentation Improvements or additions to documentation chart fix labels Feb 8, 2024
@github-actions github-actions bot requested a review from Yunir February 8, 2024 16:21
@apetrovYa apetrovYa merged commit 46159ba into main Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart documentation Improvements or additions to documentation fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant