Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle comments at the end of sql without a trailing newline #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: handle comments at the end of sql without a trailing newline #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82c7393
Handle comments at the end without a trailing newline
mlilius May 19, 2020
f8549ea
fixed test
mlilius May 19, 2020
cf272f4
Simplified test
mlilius May 19, 2020
00def87
Fixed a typo
mlilius May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sqlParser.jison
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
%%

[/][*](.|\n)*?[*][/] /* skip comments */
[-][-]\s.*\n /* skip sql comments */
[-][-]\s.*\n? /* skip sql comments */
[#]\s.*\n /* skip sql comments */
\s+ /* skip whitespace */

Expand Down
4 changes: 4 additions & 0 deletions test/main.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,4 +411,8 @@ describe('select grammar support', function() {
it('bugfix table alias2', function() {
testParser('select a.* from a t1 join b t2 on t1.a = t2.a')
})

it('query with comment at the end without a trailing newline', function() {
testParser('select a from b\n-- comment')
})
});