-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to Zurb Foundation #44
base: master
Are you sure you want to change the base?
Conversation
Hmm I like the idea for zurb foundation support but the implementation is a bit over the top. I think we can support both frameworks by adding the bootstrap and zurb classes.
Or we create two separate builds, zurb or bootstrap (I dont think any one really needs to support both frameworks at the same time). We would need a little more auto build magic (so we dont need an if / else in the code) |
How about a possibility to override classes and icons by defining override either via provider or two way binded attribute on directive? That only leaves template override that could be done by example in documentation? |
Overwriting classes and icons is a good idea, a bit more configuration and logical defaults are always nice. Would you mind creating a new PR with configurable classes and icons? Thanks! |
are builds done automatically? i dont have grunt installed |
Should just allow a custom template file, give developers the freedom to make their own templates. |
…r message structures
Added missing contents from previos commit (id: 7518508, Commits on Mar 27, 2015 ) incorrectly submitted to build folder instead of src
Rebuild of latest version to replace incorrect .min.js
Just a quick solution to add the css classes to use Zurb Foundation alert messages.
To enable it I have added a "foundation" attribute to the growl directive and split the css for the icons in two different files with two different grunt build tasks.