Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration to disable user close (implements #118) #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blitzmann
Copy link

@blitzmann blitzmann commented Oct 10, 2016

This pull request fulfills issue #118. Specifically:

  • Adds disableUserClose configuration. If set to true, it disables the close button (same functionality as disableCloseButton) and skips closing the message when the growl is clicked upon, effectively preventing the end user from closing the message.
  • Removes the check for clickToClose configuration. I am not sure what the purpose of this was considering I can't find any place that actually sets this option. it seems this was trying to do what I've implemented here.
  • If TTL is set, that will still close the message. If it is set to -1, the message will remain indefinitely (unless programmatically closed)

This change allows the developer to control messages that shouldn't be closed unless something else happens. For our business needs, we are using it to notify the user that they have been disconnected from the server and are attempting a reconnect. This is a message we do not wish the user to close out of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant