Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
- jshint issues
- Updated version
- Added changelog for version
  • Loading branch information
flippinjoe committed Jun 17, 2015
1 parent a672896 commit 6b600a2
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
11 changes: 8 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,15 @@
* Latest angular support
* [Finding a solution for this issue](https://github.com/JanStevens/angular-growl-2/issues/54)

**0.7.5** - 17 Jun 2015
* Fixed #76 Middle vertical alignment (@fmenezes) [pull #88](https://github.com/JanStevens/angular-growl-2/pull/88)
* Added base test suite for karma
* Fixed potential issue described in [issue #93](https://github.com/JanStevens/angular-growl-2/issues/93)

**0.7.4** - 26 May 2015
* Feature request: Return the configuration object on config methods (@disoney) [pull #73][https://github.com/JanStevens/angular-growl-2/pull/73]
* On responseError data is null, and an error is raised. (@AlexTM84) [pull #87][https://github.com/JanStevens/angular-growl-2/pull/87]
* Fix empty title and text (@asabirov) [pull #86][https://github.com/JanStevens/angular-growl-2/pull/86]
* Feature request: Return the configuration object on config methods (@disoney) [pull #73](https://github.com/JanStevens/angular-growl-2/pull/73)
* On responseError data is null, and an error is raised. (@AlexTM84) [pull #87](https://github.com/JanStevens/angular-growl-2/pull/87)
* Fix empty title and text (@asabirov) [pull #86](https://github.com/JanStevens/angular-growl-2/pull/86)

**0.7.3** - 05 Jan 2015
* Fixes issue 62 where the service was called before the directive was initialized
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angular-growl-v2",
"version": "0.7.3",
"version": "0.7.4",
"description": "growl like notifications for angularJS projects, using bootstrap alert classes",
"repository": {
"type": "git",
Expand Down
5 changes: 2 additions & 3 deletions test/growlFactoryTests.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe("growlFactory Spec", function() {

var severity;
var sampleText = 'text';
for (var i in builtinTypes) {
for (var i = 0; i < builtinTypes.length; i++) {

severity = builtinTypes[i];
expect(growlFactory[severity]).toBeDefined();
Expand Down Expand Up @@ -57,8 +57,7 @@ describe("growlFactory Spec", function() {
expect(growlMessages.getAllMessages().length).toEqual(messageCount);

growlMessages.destroyAllMessages();

expect(growlMessages.getAllMessages().length).toEqual(0);

})
});
});
2 changes: 1 addition & 1 deletion test/growlMessageServiceTests.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ describe("growlMessageService Spec", function() {

/// TESTS
it('Should be defined', function () {
expect(growlMessages).toBeDefined()
expect(growlMessages).toBeDefined();
});
});

0 comments on commit 6b600a2

Please sign in to comment.