Add a tryWriteHoldingRegister wrapper

Jalle19 · Aug 15, 2024 · 0701b9c · 0701b9c
1 parent 4afa0d5
commit 0701b9c
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/app/modbus.mjs b/app/modbus.mjs
@@ -229,7 +229,8 @@ export const getSettings = async (modbusClient) => {
 }
 
 export const setSetting = async (modbusClient, setting, value) => {
-    if (AVAILABLE_SETTINGS[setting] === undefined) {
+    const dataAddress = AVAILABLE_SETTINGS[setting]
+    if (dataAddress === undefined) {
         throw new Error('Unknown setting')
     }
 
@@ -275,9 +276,9 @@ export const setSetting = async (modbusClient, setting, value) => {
 
     // This isn't very nice, but it's good enough for now
     if (coil) {
-        await mutex.runExclusive(async () => tryWriteCoil(modbusClient, AVAILABLE_SETTINGS[setting], value))
+        await mutex.runExclusive(async () => tryWriteCoil(modbusClient, dataAddress, value))
     } else {
-        await mutex.runExclusive(async () => modbusClient.writeRegister(AVAILABLE_SETTINGS[setting], intValue))
+        await mutex.runExclusive(async () => tryWriteHoldingRegister(modbusClient, dataAddress, intValue))
     }
 }
 
@@ -430,3 +431,13 @@ const tryReadHoldingRegisters = async (modbusClient, dataAddress, length) => {
         throw e
     }
 }
+
+const tryWriteHoldingRegister = async (modbusClient, dataAddress, value) => {
+    try {
+        logger.debug(`Writing ${value} to holding register address ${dataAddress}`)
+        return await modbusClient.writeRegister(dataAddress, value)
+    } catch (e) {
+        logger.error(`Failed to write holding register address ${dataAddress}, value ${value}`)
+        throw e
+    }
+}