For request failures and timeouts, include the URLs in the errors #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giles-v
commented
Dec 18, 2024
| @@ -558,13 +558,13 @@ export function fetch(input, init) { | |||
|
|
|||
| xhr.onerror = function() { | |||
| setTimeout(function() { | |||
| reject(new TypeError('Network request failed')) | |||
| reject(new TypeError('Network request ('+request.method+' '+request.url+') failed')) | |||
There was a problem hiding this comment.
These would be neater as string template literals, but since those were not currently in use in the codebase, I opted to match the existing style of plain strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with complex Jest tests which mount large component trees, it can be difficult to nail down which request is causing test failures with the current message. Echo the specific method and URL into the Error, so that debugging is easier.