[MP] fix water jumping discrepancy #1212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reverts a change introduced in Razish/jasdk_modbase@09edabf but provide an alternative fix that better matches SP code/behaviour with as few changes as possible this lets you jump out of the water pools in taspir2 like you can in SP introduces g_fixWaterJump (default: 0) / LEGACYFIX_WATERJUMP discovered by @CansecoDev
SomaZ
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts a change introduced in Razish/jasdk_modbase@09edabf but provide an alternative fix that better matches SP code/behaviour with as few changes as possible
this lets you jump out of the water pools in
taspir2like you can in SPintroduces
g_fixWaterJump(default: 0) /LEGACYFIX_WATERJUMPTo be clear, OpenJK modules currently let you jump out of pools because we "fixed" a contents check. They shouldn't. But rather than remove that ability outright, I'm putting it behind a legacy fix option that better matches SP code.
discovered by @CansecoDev
SP:
https://github.com/JACoders/OpenJK/assets/844370/5ebdd10e-7ca5-4ab9-bf3e-c581b5934c25
MP original behaviour:
https://github.com/JACoders/OpenJK/assets/844370/2423b20b-52ae-4ab3-ba95-ad38ccff5e6d