Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plutus-tx-template.yml #6489

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Update plutus-tx-template.yml #6489

merged 1 commit into from
Sep 17, 2024

Conversation

zliu41
Copy link
Member

@zliu41 zliu41 commented Sep 16, 2024

The job is broken by IntersectMBO/plutus-tx-template#20.

@zliu41 zliu41 added the No Changelog Required Add this to skip the Changelog Check label Sep 16, 2024
@zliu41 zliu41 requested review from zeme-wana and a team September 16, 2024 19:56
docker run \
-v ./.:/workspaces/plutus-tx-template \
-w /workspaces/plutus-tx-template \
-i ghcr.io/input-output-hk/devx-devcontainer:x86_64-linux.ghc96-iog \
bash -ic "cabal update && cabal run plutus-tx-template && test -e validator.uplc"
bash -ic "cabal update && cabal build all"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to run any test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no test to run at the moment. The old command simply runs the executable, and checks that the output file exists, which isn't testing much, and now it no longer works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zeme-wana zeme-wana merged commit e2016d5 into master Sep 17, 2024
6 of 7 checks passed
@zeme-wana zeme-wana deleted the zliu41/template branch September 17, 2024 09:39
v0d1ch pushed a commit to v0d1ch/plutus that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants