Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add n-way table unions #489

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Add n-way table unions #489

merged 7 commits into from
Dec 10, 2024

Conversation

jorisdral
Copy link
Collaborator

n-way table unions should be more performant than repeated 2-way unions

@jorisdral jorisdral self-assigned this Dec 6, 2024
@jorisdral
Copy link
Collaborator Author

This is a WIP, so not reviewable just yet

@jorisdral jorisdral marked this pull request as ready for review December 6, 2024 14:19
@jorisdral
Copy link
Collaborator Author

Should be ready for review now! Note that this PR is built on top of #486.

Base automatically changed from jdral/unified-class-tests to main December 10, 2024 14:44
dcoutts
dcoutts reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks fine, though seems to me there's no need to exclude the trivial case of n == 1.

src/Database/LSMTree/Monoidal.hs Outdated Show resolved Hide resolved
src/Database/LSMTree/Normal.hs Outdated Show resolved Hide resolved
test/Database/LSMTree/Model/Session.hs Outdated Show resolved Hide resolved
test/Database/LSMTree/Model/Session.hs Show resolved Hide resolved
test/Database/LSMTree/Model/Table.hs Show resolved Hide resolved
test/Test/Database/LSMTree/StateMachine.hs Show resolved Hide resolved
test/Test/Database/LSMTree/StateMachine.hs Show resolved Hide resolved
test/Test/Database/LSMTree/StateMachine.hs Outdated Show resolved Hide resolved
test/Test/Database/LSMTree/StateMachine.hs Show resolved Hide resolved
dcoutts
dcoutts approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, meant to approve, not just comment.

dcoutts
dcoutts approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dcoutts dcoutts enabled auto-merge December 10, 2024 16:00
@dcoutts dcoutts mentioned this pull request Dec 10, 2024
Merged
@dcoutts dcoutts added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit e256e9b Dec 10, 2024
27 checks passed
@dcoutts dcoutts deleted the jdral/n-way-unions branch December 10, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts dcoutts approved these changes

@mheinzel mheinzel Awaiting requested review from mheinzel mheinzel is a code owner

@recursion-ninja recursion-ninja Awaiting requested review from recursion-ninja recursion-ninja is a code owner

@wenkokke wenkokke Awaiting requested review from wenkokke wenkokke is a code owner

Assignees

@jorisdral jorisdral

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisdral @dcoutts