Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1713): fix inconsistent voting status #2433

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix(#1713): fix inconsistent voting status #2433

merged 1 commit into from
Nov 29, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • fix inconsistent voting status

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Nov 27, 2024 that may be closed by this pull request
[BUG] Inconsistent Voting Status Causing Re-Vote on Governance Actions #1713
Closed
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/1713-bug-inconsistent-voting-status-causing-re-vote-on-governance-actions branch from 29070f2 to fd85bcf Compare November 27, 2024 22:02
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/1713-bug-inconsistent-voting-status-causing-re-vote-on-governance-actions branch from fd85bcf to f68bc44 Compare November 28, 2024 06:28
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski requested a review from placek November 29, 2024 10:49
@MSzalowski MSzalowski force-pushed the fix/1713-bug-inconsistent-voting-status-causing-re-vote-on-governance-actions branch from f68bc44 to e68c943 Compare November 29, 2024 10:51
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski merged commit 5d433b7 into develop Nov 29, 2024
10 checks passed
@MSzalowski MSzalowski deleted the fix/1713-bug-inconsistent-voting-status-causing-re-vote-on-governance-actions branch November 29, 2024 11:06
@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-5d433b747c0ce150c7af144e8e3bfe21f2bca3da , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-5d433b747c0ce150c7af144e8e3bfe21f2bca3da , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Inconsistent Voting Status Causing Re-Vote on Governance Actions
2 participants
@MSzalowski @placek