fix(#2192): Optimize and fix vulnerabilities in frontend and metadata…

… services
IntersectMBO · Dec 6, 2024 · 238de14 · 238de14
1 parent c25912d
commit 238de14
Show file tree

Hide file tree

Showing 47 changed files with 5,298 additions and 33,736 deletions.
diff --git a/.github/workflows/code_check_frontend.yml b/.github/workflows/code_check_frontend.yml
@@ -34,8 +34,6 @@ jobs:
           NODE_AUTH_TOKEN: ${{ secrets.NPMRC_TOKEN }}
 
       - name: 🧪 Test
-        env:
-          NODE_OPTIONS: "--max_old_space_size=8192"
         run: |
           npm run test
 

diff --git a/.github/workflows/frontend_sonar_scan.yml b/.github/workflows/frontend_sonar_scan.yml
@@ -31,7 +31,6 @@ jobs:
       - name: 🧪 Test
         working-directory: govtool/frontend
         env:
-          NODE_OPTIONS: "--max_old_space_size=6144"
           NODE_AUTH_TOKEN: ${{ secrets.NPMRC_TOKEN }}
         run: |
           npm ci

diff --git a/.github/workflows/test_storybook.yml b/.github/workflows/test_storybook.yml
@@ -16,9 +16,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version-file: "govtool/frontend/.nvmrc"
       - name: Install dependencies
         run: |
           npm config set @intersect.mbo:registry "https://registry.npmjs.org/" --location=global
@@ -27,7 +27,7 @@ jobs:
       - name: Install Playwright
         run: npx playwright install --with-deps
       - name: Build Storybook
-        run: NODE_OPTIONS="--max-old-space-size=8046" npm run build:storybook --quiet
+        run: npm run build:storybook --quiet
       - name: Serve Storybook and run tests
         run: |
           npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,7 +16,8 @@ changes.
 
 ### Fixed
 
--
+- Fix vulnerabilities in dependencies [Issue 2192](https://github.com/IntersectMBO/govtool/issues/2192)
+- Optimize resources usage in frontend service build [Issue 2192](https://github.com/IntersectMBO/govtool/issues/2192)
 
 ### Changed
 

diff --git a/govtool/frontend/.storybook/main.ts b/govtool/frontend/.storybook/main.ts
@@ -12,8 +12,6 @@ const config: StorybookConfig = {
     name: "@storybook/react-vite",
     options: {},
   },
-  docs: {
-    autodocs: "tag",
-  },
+  docs: {},
 };
 export default config;
diff --git a/govtool/frontend/Dockerfile b/govtool/frontend/Dockerfile
@@ -27,15 +27,15 @@ RUN \
   : "${VITE_IPFS_GATEWAY:?Build argument VITE_IPFS_GATEWAY is not set}" && \
   : "${VITE_IPFS_PROJECT_ID:?Build argument VITE_IPFS_PROJECT_ID is not set}"
 
-ENV NODE_OPTIONS=--max_old_space_size=8192
-
 WORKDIR /src
 
 # Set npm configuration settings using environment variables
 RUN npm config set @intersect.mbo:registry "https://registry.npmjs.org/" --location=global
 RUN npm config set //registry.npmjs.org/:_authToken ${NPMRC_TOKEN} --location=global
 
 COPY package.json package-lock.json ./
+COPY patches ./patches
+
 RUN npm install
 COPY . .
 RUN npm run build

diff --git a/govtool/frontend/Dockerfile.qovery b/govtool/frontend/Dockerfile.qovery
@@ -13,15 +13,15 @@ ARG VITE_PDF_API_URL
 ARG VITE_IPFS_GATEWAY
 ARG VITE_IPFS_PROJECT_ID
 
-ENV NODE_OPTIONS=--max_old_space_size=8192
-
 WORKDIR /src
 
 # Set npm configuration settings using environment variables
 RUN npm config set @intersect.mbo:registry "https://registry.npmjs.org/" --location=global
 RUN npm config set //registry.npmjs.org/:_authToken ${NPMRC_TOKEN} --location=global
 
 COPY package.json package-lock.json ./
+COPY patches ./patches
+
 RUN npm install
 COPY . .
 RUN npm run build

diff --git a/govtool/frontend/junit-report.xml b/govtool/frontend/junit-report.xml