Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix #2447 #2264 #35

Closed
wants to merge 4 commits into from
Closed

BugFix #2447 #2264 #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c51806f
Change address and amount to be an array
nebojsajsimic Dec 2, 2024
ea1e1fe
BugFix 2264 - After successeful subbmition of GA yo uwill be redirect…
nebojsajsimic Dec 2, 2024
6f4de8c
Update CHANGELOG.md
nebojsact Dec 2, 2024
4718786
Merge branch 'main' into BugFix-#2447
nebojsact Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pdf-ui/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
As a minor extension, we also keep a semantic version for the `UNRELEASED`
changes.

## [v0.5.2](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.2) 2024-12-02

### Added -
### Fixed -
- Changed params for submitting GA so now it is change to multiple addresses. [issue #2447](https://github.com/IntersectMBO/govtool/issues/2447)
- After successful submission of GA modal close button will redirect to dashboard instead of allowing to submit again.[issue #2264](https://github.com/IntersectMBO/govtool/issues/2264)
### Changed -
### Removed -

## [v0.5.1](https://www.npmjs.com/package/@intersect.mbo/pdf-ui/v/0.5.1) 2024-11-29

### Added -
Expand All @@ -32,4 +41,5 @@ changes.
### Added -
### Fixed -
### Changed -
### Removed -
### Removed -

2 changes: 1 addition & 1 deletion pdf-ui/src/components/SubmissionGovernanceAction/Modals/GovernanceActionSubmittedModal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const GovernanceActionSubmittedModal = ({ open, onClose }) => {
alignItems={'center'}
>
<IconButton
onClick={onClose}
onClick={() => navigate('/proposal_discussion')}
data-testid='ga-submitted-modal-close-button'
>
<IconX width='24px' height='24px' />
Expand Down
14 changes: 10 additions & 4 deletions pdf-ui/src/components/SubmissionGovernanceAction/Steps/InformationStorageStep.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,7 @@ const InformationStorageStep = ({ proposal, handleCloseSubmissionDialog }) => {
await walletAPI.buildTreasuryGovernanceAction({
hash: hashData,
url: fileURL,
amount: proposal?.attributes?.content?.attributes?.prop_amount?.toString(),
receivingAddress:
proposal?.attributes?.content?.attributes
?.prop_receiving_address,
withdrawals: getWithdrawalsArray()
});
}

Expand Down Expand Up @@ -183,6 +180,15 @@ const InformationStorageStep = ({ proposal, handleCloseSubmissionDialog }) => {
}
};

const getWithdrawalsArray = () => {
let withdrawalsArray = [];
let x = proposal?.attributes?.content?.attributes?.proposal_withdrawals.forEach((withdrawal) =>
{
withdrawalsArray.push({receivingAddress:withdrawal.prop_receiving_address,amount:withdrawal.prop_amount.toString()})
});
return withdrawalsArray;
}

const handleDownloadJsonLD = () => {
const blob = new Blob([JSON.stringify(jsonLdData, null, 2)], {
type: 'application/ld+json',
Expand Down