Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a proper EnterpriseAddr type #612

Closed
wants to merge 1 commit into from
Closed

Add a proper EnterpriseAddr type #612

wants to merge 1 commit into from

Conversation

WhatisRT
Copy link
Collaborator

Description

Replace the Maybe in the stake field of BaseAddr with a proper EnterpriseAddr type.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any semantic changes to the specifications are documented in CHANGELOG.md
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@lehins
Copy link

lehins commented Nov 18, 2024

This approach does not match Haskell implementation. Less discrepancies we have the better.
Instead we just need to add a comment here saying that Nothing means an "Enterprise" address:

formal-ledger-specifications/src/Ledger/Address.lagda

Line 62 in f93035b

stake : Maybe Credential

@lehins lehins closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdemeo williamdemeo Awaiting requested review from williamdemeo

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WhatisRT @lehins