Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix deployment of PDFs #232

Merged
merged 1 commit into from
Oct 4, 2023
Merged

CI: fix deployment of PDFs #232

merged 1 commit into from
Oct 4, 2023

Conversation

omelkonian
Copy link
Collaborator

Fix #230 (introduced by PR #217).

@omelkonian omelkonian added the ci label Oct 3, 2023
WhatisRT
WhatisRT approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why -f would be necessary, but it certainly won't hurt

@WhatisRT WhatisRT merged commit 4e797b5 into master Oct 4, 2023
1 check passed
@WhatisRT WhatisRT deleted the fix-ci branch October 4, 2023 09:37
@omelkonian
Copy link
Collaborator Author

I don't see why -f would be necessary, but it certainly won't hurt

Finally understood how the issue arose: in #217 I extended the .gitignore to play well with the new Makefile and added this line:

*.pdf

...which is sensible, given that we are not putting generated PDFs under version control.
But this confuses the CI deployment to the gh-pages branch, in which case forcing with -f also seems sensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhatisRT WhatisRT WhatisRT approved these changes

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken links to pdfs of specs
2 participants
@omelkonian @WhatisRT