Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce (Bi)functor interface #226

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Introduce (Bi)functor interface #226

merged 2 commits into from
Sep 29, 2023

Conversation

omelkonian
Copy link
Collaborator

Provides a uniform way (i.e. typeclass) to perform (bi)functorial actions, rather than having to remember the names of each instantiation/module.

@omelkonian omelkonian added the enhancement New feature or request label Sep 28, 2023
@WhatisRT
Copy link
Collaborator

Thank you, that's a great addition! What do you think about renaming fmap to map? Obviously it has name clashes everywhere, but since we're already going in the direction of putting using on our imports that shouldn't really matter.

- The universe levels in `Axiom.Set` do not allow for a functor
instance; renamed to mapˢ until we find a solution (if there's any).
Copy link
Collaborator

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omelkonian omelkonian merged commit 6b7d4cc into master Sep 29, 2023
1 check passed
@omelkonian omelkonian deleted the functor-class branch September 29, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants