Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computational instance for GOV' rule #223

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Computational instance for GOV' rule #223

merged 4 commits into from
Sep 25, 2023

Conversation

UlfNorell
Copy link
Collaborator

@UlfNorell UlfNorell commented Sep 19, 2023

This doesn't do anything about #212, the existing definition of the rule is computational even without enforcing unique GovActionIds.

Question: This defines any⇔∃ locally with the computational instance, but it feels like something that should either already be in the standard library (where I couldn't find it), or be defined in some more reasonable place in our repo.

@UlfNorell UlfNorell requested a review from WhatisRT September 19, 2023 16:09
@WhatisRT
Copy link
Collaborator

I found it, it's Any↔ from Data.List.Membership.Propositional.Properties. However, it's still in the old function hierarchy, so I had to convert it to the new one. That conversion function is exactly the reason why we're not on any released version of the stdlib btw.

@WhatisRT WhatisRT merged commit b862cfd into master Sep 25, 2023
@WhatisRT WhatisRT deleted the GOV-computational branch September 25, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants