-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements and fixes related to logging, metrics, and testing #6052
Conversation
e85b48e
to
a2d1784
Compare
a4be095
to
973d9cd
Compare
Would it be difficult to also enable logging of the reason for "SwitchedToAFork"? IE: Longer chain vs Equal length but terminal block had lower VRF? |
b75ff9a
to
4dee70f
Compare
4dee70f
to
3b6db29
Compare
3b6db29
to
2146f13
Compare
@TerminadaDrep I've looked at the issue, and the data traced by |
7c7c2f4
to
afaf32e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @jutaro
Summary
This pull request addresses multiple enhancements and fixes related to logging, metrics, and testing in the project.
Changes
Let the Forging Mode metrics respect the command line config
Enhanced Logging for Chain Events
tipBlockHash
: Hash of the current tip block.tipBlockParentHash
: Hash of the parent block of the tip.tipBlockIssuerVerificationKeyHash
: Hash of the verification key of the tip block issuer.SwitchedToAFork
AddedToCurrentChain
Consistency Testing for Mainnet Configuration
Testing
SwitchedToAFork
,AddedToCurrentChain
).Checklist
Linked Issue
Closes #5751