Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] - Log reason when node switches tip to a fork #6014

Open
TerminadaPool opened this issue Oct 15, 2024 · 6 comments
Open

[FR] - Log reason when node switches tip to a fork #6014

TerminadaPool opened this issue Oct 15, 2024 · 6 comments
Labels
needs triage Issue / PR needs to be triaged. type: enhancement An improvement on the existing functionality

Comments

@TerminadaPool
Copy link

Internal/External
External: Stake pool operator

Area
Other: Logging

Describe the feature you'd like
Please log the reason why the node preferred another fork

Describe alternatives you've considered
The independent tool cncli provides logging of block data including the block VRF value into a sqlite database. This database can be queried for insight into whether the likely reason the node preferred another fork was because the other fork terminal block had a lower block VRF and the tie break rule was applied.

Additional context / screenshots
The node knows the reason for switching tip to a competing fork but this reason isn't logged. Rather the logs only confirm that the tip was switched. But, was the reason due to the competing fork being longer? Or was it due to the other fork's terminal block having a lower VRF causing the tie-break rule to be applied? Or did the node prefer another fork some other reason?

This information would be really helpful when trying to identify what caused your own block to not be adopted.

@TerminadaPool TerminadaPool added needs triage Issue / PR needs to be triaged. type: enhancement An improvement on the existing functionality labels Oct 15, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Nov 15, 2024
@TerminadaPool
Copy link
Author

Please stay as an open feature request.

@rphair
Copy link

rphair commented Nov 15, 2024

Yes, please: if this is considered impractical to add I would like to hear why. Our SPO operation believes this is important for quality assurance purposes.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Dec 16, 2024
@rphair
Copy link

rphair commented Dec 16, 2024

@carbolymer what kind of engagement do the developers expect for this issue not to be Stale? There won't be anything new to report until someone in the relevant team finally responds.

This log info has been long & vitally requested for diagnostic purposes and the need for it is never going to go away. Those who need it most would be small stake pools with infrequent blocks... and therefore needed more in the near future if & when the K PoS parameter increases (as is constantly suggested in governance conversations).

If this issue keeps being dismissed, the implication is that QA isn't very important for stake pools and/or chain density isn't that important for Cardano itself. I don't think either of these things are true and I can state from SPO experience dating back to the beginning of the Shelley period that implementing this feature (which we arguably should have had from day 1) would be helpful for SPOs and node infrastructure operators at all levels of endeavour.

@github-actions github-actions bot removed the Stale label Dec 17, 2024
@carbolymer
Copy link
Contributor

There was a slack discussion about this issue some time ago.
@jasagredo @amesgen would you mind sharing main takeaways here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue / PR needs to be triaged. type: enhancement An improvement on the existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants