Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SpecTranslate instance of AlonzoScript, debug info improvements #4801

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Dec 17, 2024

Description

This PR updates the translation of AlonzoScript by including the script hash. I also added some additional debug information to conformance testing and made Agda credentials display the hashes correctly.

related IntersectMBO/formal-ledger-specifications#628

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/conformance-investigation branch 6 times, most recently from c7f50f9 to 9b90011 Compare December 18, 2024 13:36
@Soupstraw Soupstraw changed the title Jj/conformance investigation Updated SpecTranslate instances of PlutusScript and TxCert Dec 18, 2024
@Soupstraw Soupstraw changed the title Updated SpecTranslate instances of PlutusScript and TxCert Updated SpecTranslate instances of AlonzoScript and TxCert Dec 18, 2024
@Soupstraw Soupstraw changed the title Updated SpecTranslate instances of AlonzoScript and TxCert Updated SpecTranslate instance of AlonzoScript Dec 18, 2024
@Soupstraw Soupstraw changed the title Updated SpecTranslate instance of AlonzoScript Updated SpecTranslate instance of AlonzoScript, debug info improvements Dec 18, 2024
@Soupstraw Soupstraw marked this pull request as ready for review December 18, 2024 13:38
@Soupstraw Soupstraw requested a review from a team as a code owner December 18, 2024 13:38
@Soupstraw Soupstraw force-pushed the jj/conformance-investigation branch from 9b90011 to a8f95ed Compare December 18, 2024 13:38
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants