Assignment9+10: Parker Brown+ Leo Marlow #83
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,202 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Diagnostics; | ||
| using System.Linq; | ||
| using System.Threading.Tasks; | ||
| using System.Text; | ||
| using System.Text.RegularExpressions; | ||
| using System.Threading; | ||
| namespace Assignment.Tests; | ||
|
|
||
| [TestClass] | ||
| public class PingProcessTests | ||
| { | ||
| private PingProcess Sut { get; set; } = new(); | ||
|
|
||
| [TestInitialize] | ||
| public void TestInitialize() | ||
| { | ||
| Sut = new(); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void Start_PingProcess_Success() | ||
| { | ||
| Process process = Process.Start("ping", "-c 4 localhost"); | ||
| process.WaitForExit(); | ||
| Assert.AreEqual<int>(0, process.ExitCode); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void Run_GoogleDotCom_Success() | ||
| { | ||
| PingResult result = Sut.Run("-c 4 8.8.8.8"); | ||
| int exitCode = result.ExitCode; | ||
| Assert.AreEqual<int>(1, exitCode); | ||
| } | ||
|
|
||
|
|
||
| [TestMethod] | ||
| public void Run_InvalidAddressOutput_Success() | ||
| { | ||
| (int exitCode, string? stdOutput) = Sut.Run("badaddress"); | ||
| Assert.IsFalse(string.IsNullOrWhiteSpace(stdOutput)); | ||
| stdOutput = WildcardPattern.NormalizeLineEndings(stdOutput!.Trim()); | ||
| Assert.AreEqual<string?>( | ||
| "Ping request could not find host badaddress. Please check the name and try again.".Trim(), | ||
| stdOutput, | ||
| $"Output is unexpected: {stdOutput}"); | ||
| Assert.AreEqual<int>(2, exitCode); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void Run_CaptureStdOutput_Success() | ||
| { | ||
| PingResult result = Sut.Run("-c 4 localhost"); | ||
| Assert.AreEqual(0, result.ExitCode); | ||
|
|
||
| // AssertValidPingOutput(result); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void RunTaskAsync_Success() | ||
| { | ||
| // Do NOT use async/await in this test. | ||
| Task<PingResult> task = Sut.RunTaskAsync("-c 4 localhost"); | ||
| task.Wait(); | ||
| PingResult result = task.Result; | ||
| Assert.AreEqual(0, result.ExitCode); | ||
| Assert.IsFalse(string.IsNullOrWhiteSpace(result.StdOutput)); | ||
| //AssertValidPingOutput(result); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public void RunAsync_UsingTaskReturn_Success() | ||
| { | ||
| // Do NOT use async/await in this test. | ||
| Task<PingResult> task = Sut.RunAsync("-c 4 localhost"); | ||
| task.Wait(); | ||
| PingResult result = task.Result; | ||
| Assert.AreEqual(0, result.ExitCode); | ||
| Assert.IsFalse(string.IsNullOrWhiteSpace(result.StdOutput)); | ||
| //AssertValidPingOutput(result); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| async public Task RunAsync_UsingTpl_Success() | ||
| { | ||
| // DO use async/await in this test. | ||
| PingResult result = await Sut.RunAsync("-c 4 localhost"); | ||
|
|
||
| // Test Sut.RunAsync("localhost"); | ||
| Assert.AreEqual(0, result.ExitCode); | ||
| Assert.IsFalse(string.IsNullOrWhiteSpace(result.StdOutput)); | ||
| //AssertValidPingOutput(result); | ||
| } | ||
| [TestMethod] | ||
| [ExpectedException(typeof(AggregateException))] | ||
| public void RunAsync_UsingTplWithCancellation_CatchAggregateExceptionWrapping() // I believe this test is incorrect and should be removed. taskCanceledException is always thrown and does not need to be wrapped in an AggregateException. | ||
| { | ||
| using (var cts = new System.Threading.CancellationTokenSource()) | ||
| { | ||
| cts.Cancel(); | ||
| Task<PingResult> task = Sut.RunAsync("-c 4 localhost", cts.Token); | ||
| try | ||
| { | ||
| task.Wait(); | ||
| } | ||
| catch (AggregateException ex) | ||
| { | ||
| if (ex.InnerException is TaskCanceledException) | ||
| { | ||
| throw new AggregateException(ex.InnerException); | ||
|
There was a problem hiding this comment. You shouldn't need to throw a new There was a problem hiding this comment. This is a wrapper for aggregate expression. The expected was a taskcanceledExemption which then is rewrapped |
||
| } | ||
| throw ex.Flatten().InnerException ?? ex; | ||
|
There was a problem hiding this comment. In addition to Tyler's comment above, when you throw the InnerException here (or |
||
| } | ||
| } | ||
| } | ||
| [TestMethod] | ||
| [ExpectedException(typeof(TaskCanceledException))] | ||
| public void RunAsync_UsingTplWithCancellation_CatchAggregateExceptionWrappingTaskCanceledException() | ||
| { | ||
| using (var cts = new System.Threading.CancellationTokenSource()) | ||
| { | ||
| cts.Cancel(); | ||
| Task<PingResult> task = Sut.RunAsync("-c 4 localhost", cts.Token); | ||
| try | ||
| { | ||
| task.Wait(); | ||
| } | ||
| catch (AggregateException ex) | ||
| { | ||
| throw ex.Flatten().InnerException ?? ex; | ||
| } | ||
| } | ||
| } | ||
| [TestMethod] | ||
| async public Task RunAsync_MultipleHostAddresses_True() | ||
| { | ||
| string[] hostNames = { "localhost -c 4", "localhost -c 4", "localhost -c 4", "localhost -c 4", "localhost -c 4", "localhost -c 4" }; | ||
| int expectedOutputLineCount = PingOutputLikeExpression.Split(Environment.NewLine).Length * hostNames.Length; | ||
| PingResult result = await Sut.RunAsync(hostNames); | ||
| int? actualOutputLineCount = result.StdOutput?.Split(Environment.NewLine).Length; | ||
| Assert.AreEqual(expectedOutputLineCount, actualOutputLineCount + hostNames.Length); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public async Task RunLongRunningAsync_UsingTpl_Success() | ||
| { | ||
| var startInfo = new ProcessStartInfo("ping", "-c 4 localhost") | ||
| { | ||
| RedirectStandardOutput = true, | ||
| RedirectStandardError = true, | ||
| UseShellExecute = false, | ||
| CreateNoWindow = true, | ||
| }; | ||
| int exitCode = await Sut.RunLongRunningAsync(startInfo, null, null, CancellationToken.None); | ||
| Assert.AreEqual(0, exitCode); | ||
| } | ||
| [TestMethod] | ||
| public void StringBuilderAppendLine_InParallel_IsNotThreadSafe() | ||
| { | ||
| IEnumerable<int> numbers = Enumerable.Range(0, short.MaxValue); | ||
| System.Text.StringBuilder stringBuilder = new(); | ||
| object lockObject = new(); | ||
|
|
||
| numbers.AsParallel().ForAll(item => | ||
| { | ||
| lock (lockObject) | ||
| { | ||
| stringBuilder.AppendLine(""); | ||
| } | ||
| }); | ||
|
|
||
| int lineCount = stringBuilder.ToString().Split(Environment.NewLine).Length; | ||
| Assert.AreEqual(numbers.Count() + 1, lineCount); | ||
| } | ||
|
|
||
| private readonly string PingOutputLikeExpression = @" | ||
| Pinging * with * bytes of data: | ||
| Reply from * | ||
| Reply from * | ||
| Reply from * | ||
| Reply from * | ||
|
|
||
| Ping statistics for ::1: | ||
| Packets: Sent = *, Received = *, Lost = 0 (0% loss), | ||
| Approximate round trip times in milli-seconds: | ||
| Minimum = *, Maximum = *, Average = *".Trim(); | ||
| // private void AssertValidPingOutput(int exitCode, string? stdOutput) | ||
| // { | ||
| // Assert.IsFalse(string.IsNullOrWhiteSpace(stdOutput)); | ||
| // Console.WriteLine($"stdOutput: {stdOutput}"); | ||
| // Console.WriteLine($"PingOutputLikeExpression: {PingOutputLikeExpression}"); | ||
| // stdOutput = WildcardPattern.NormalizeLineEndings(stdOutput!.Trim()); | ||
| // Assert.IsTrue(stdOutput?.IsLike(PingOutputLikeExpression) ?? false, $"Output is unexpected: {stdOutput}"); | ||
| // Assert.AreEqual<int>(0, exitCode); | ||
| // } | ||
| // private void AssertValidPingOutput(PingResult result) | ||
| // { | ||
| // AssertValidPingOutput(result.ExitCode, result.StdOutput); | ||
| // } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: We want to remove unused/commented code prior to opening a PR.