Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move package into a monorepo #519

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from

Conversation

ahmedAlaaInstabug
Copy link
Contributor

Description of the change

Create monorepo for instabug-flutter

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA ID : MOB-16329

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug changed the base branch from master to dev October 18, 2024 01:14
@ahmedAlaaInstabug ahmedAlaaInstabug changed the title refator: monoRepo Refactor: mono-repo Oct 18, 2024
@InstabugCI
Copy link
Collaborator

InstabugCI commented Oct 18, 2024

Coverage Report

Label Coverage Status
instabug_flutter 80.4%

Generated by 🚫 dangerJS against 4bbafb0

Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing effort on this @ahmedAlaaInstabug 👏🏼❤️

I feel like we can rename packages/Instabug-Flutter to the actual pub.dev package name packages/instabug_flutter, we can do the same for the rest of the packages once added as well.
An alternative would be to rename it to core and the rest would be dio, http, flutter_modular etc.
What do you think?

.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@a7medev a7medev changed the title Refactor: mono-repo refactor: move package into a monorepo Oct 27, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug changed the title refactor: move package into a monorepo Refactor: move package into a monorepo Oct 28, 2024
* refactor: monoRepo dev changes

* refactor: monoRepo dev changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants