Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INSD-9439] Add New Locales #363

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

[INSD-9439] Add New Locales #363

wants to merge 19 commits into from

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented May 11, 2023 •
edited
Loading

Description of the change

Caution

⚠️ 🚫 DON'T MERGE ME 🚫 ⚠️ ⚠️ 🚫 DON'T MERGE ME 🚫 ⚠️ ⚠️ 🚫 DON'T MERGE ME 🚫 ⚠️

PR for running CI and handling BDR Thermea's releases.

Adds support for the below new locales:

  1. Bulgarian
  2. Croatian
  3. Estonian
  4. Greek
  5. Latvian
  6. Lithuanian
  7. Serbian
  8. Slovenian
  9. Ukrainian

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this May 11, 2023
@a7medev a7medev added pending-android Waiting for Android release pending-ios Waiting for iOS release labels May 11, 2023
@a7medev a7medev changed the base branch from master to dev May 11, 2023 21:44
@InstabugCI
Copy link
Collaborator

InstabugCI commented May 11, 2023 •
edited
Loading

Coverage Report

Label Coverage Status
Dart 82.0% ✅

Generated by 🚫 dangerJS against 38df50f

@a7medev a7medev force-pushed the feature/add-new-locales branch from 831ca5e to 3379cd4 Compare May 15, 2023 07:29
@a7medev a7medev requested a review from DavidMina96 May 17, 2023 15:31
Base automatically changed from dev to master May 30, 2023 10:29
@a7medev a7medev force-pushed the feature/add-new-locales branch from 4d1f7f9 to 82d6549 Compare July 13, 2023 13:56
@a7medev a7medev removed the request for review from DavidMina96 October 2, 2023 15:15
@a7medev a7medev force-pushed the feature/add-new-locales branch from 6b7d67d to 1fcfc82 Compare October 2, 2023 15:17
@abdelhamid-f-nasser abdelhamid-f-nasser force-pushed the feature/add-new-locales branch 3 times, most recently from 25f23c0 to b97c887 Compare November 30, 2023 17:57
@a7medev a7medev removed pending-android Waiting for Android release pending-ios Waiting for iOS release labels Jun 27, 2024
@a7medev a7medev marked this pull request as draft June 27, 2024 08:47
@a7medev a7medev force-pushed the feature/add-new-locales branch from b97c887 to e44b2de Compare June 27, 2024 08:51
@a7medev a7medev force-pushed the feature/add-new-locales branch from 25b8b1c to 38df50f Compare July 12, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7medev @InstabugCI @abdelhamid-f-nasser