Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake advanced mac #4671

Merged
merged 2 commits into from
May 16, 2024

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented May 16, 2024

Mark advanced CMake variables as advanced. Closes #4629

Corresponding GDCM PR: malaterre/GDCM#175

thewtex added 2 commits May 16, 2024 13:29
This was non-advanced due to its high module compliance rating. However,
there are no other remote modules the same, and it is odd to just
have FastBilateral as non-advanced. A revisit to making it non-advanced
could be made after re-evaluating all the remote modules' compliance
rating.
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:ThirdParty Issues affecting the ThirdParty module type:Data Changes to testing data labels May 16, 2024
Copy link
Member

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Contributor

@seanm seanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thewtex thewtex merged commit f63625e into InsightSoftwareConsortium:master May 16, 2024
14 checks passed
@thewtex thewtex deleted the cmake-advanced-mac branch May 16, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ThirdParty Issues affecting the ThirdParty module type:Data Changes to testing data type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detailed CMake options are not marked as advanced.
4 participants