Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Ensure ratio arg is used in two-way crosstabs #947

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

IndrajeetPatil
Copy link
Owner

@IndrajeetPatil IndrajeetPatil commented Jul 7, 2024

Closes #818

library(ggstatsplot)
#> You can cite this package as:
#>      Patil, I. (2021). Visualizations with statistical details: The 'ggstatsplot' approach.
#>      Journal of Open Source Software, 6(61), 3167, doi:10.21105/joss.03167
df <- tibble::tibble(
  group = c(rep("control", 3), rep("treatment", 3)),
  sex = c("male", "female", "other", "male", "male", "female")
)

ggpiestats(df, sex, group)

ggpiestats(df, sex, group, ratio = c(0.45, 0.45, 0.10))

ggbarstats(df, sex, group)

ggbarstats(df, sex, group, ratio = c(0.45, 0.45, 0.10))

Created on 2024-07-07 with reprex v2.1.1

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (18c8921) to head (5c6ca1a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #947   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          770       760   -10     
=========================================
- Hits           770       760   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil IndrajeetPatil merged commit ce9b7bb into main Jul 7, 2024
24 checks passed
@IndrajeetPatil IndrajeetPatil deleted the f818-prop-test-ratio branch July 7, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ratio" argument in ggpiestats/ggbarstats seems dysfunctional
1 participant