Fix failing tests from easystats updates (#974)

* Style with latest styler

* consolidate warning-as-errors into one workflow

.github/workflows/check-test-warnings.yaml → .github/workflows/check-no-warnings.yaml

@@ -1,14 +1,14 @@
-# Run tests with `options(warn = 2)` to fail on test warnings
+# execute all examples, tests, and vignettes with warnings turned into errors
 on:
   push:
     branches: [main, master]
   pull_request:
     branches: [main, master]
 
-name: check-test-warnings
+name: check-no-warnings
 
 jobs:
-  check-test-warnings:
+   check-no-warnings:
     runs-on: ubuntu-latest
     env:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
@@ -18,25 +18,38 @@ jobs:
 
       - uses: r-lib/actions/setup-r@v2
         with:
-          r-version: "devel"
           use-public-rspm: true
 
       - uses: r-lib/actions/setup-r-dependencies@v2
         with:
           pak-version: devel
-          upgrade: 'TRUE'
           extra-packages: |
+            any::devtools
             local::.
-          needs: check
+
+      - name: Run examples
+        run: |
+          options(crayon.enabled = TRUE,  warn = 2L)
+          devtools::run_examples(fresh = TRUE, run_dontrun = TRUE, run_donttest = TRUE)
+        shell: Rscript {0}
 
       - name: Run Tests
         run: |
             options(crayon.enabled = TRUE)
             pkgload::load_all()
+            # this workaround needed to play nicely with parallel testing
+            # see: https://github.com/r-lib/testthat/issues/1912
             test_script_paths <- testthat::find_test_scripts("tests/testthat")
             test_with_warning_as_error <- function(path) {
               withr::local_options(list(warn = 2L))
               testthat::test_file(path, stop_on_failure = TRUE, stop_on_warning = TRUE)
             }
             purrr::walk(test_script_paths, test_with_warning_as_error)
         shell: Rscript {0}
+
+      - name: Build vignettes
+        run: |
+          options(crayon.enabled = TRUE, warn = 2L)
+          vignettes <- fs::dir_ls("vignettes/", glob = "*.Rmd", recurse = TRUE)
+          purrr::walk(vignettes, rmarkdown::render)
+        shell: Rscript {0}

.github/workflows/pkgdown.yaml

@@ -48,7 +48,7 @@ jobs:
 
       - name: Deploy to GitHub pages 🚀
         if: github.event_name != 'pull_request'
-        uses: JamesIves/github-pages-deploy-action@v4.6.9
+        uses: JamesIves/github-pages-deploy-action@v4.7.1
         with:
           branch: gh-pages
           folder: docs

CITATION.cff

@@ -8,7 +8,7 @@ message: 'To cite package "ggstatsplot" in publications use:'
 type: software
 license: GPL-3.0-only
 title: 'ggstatsplot: ''ggplot2'' Based Plots with Statistical Details'
-version: 0.12.5
+version: 0.12.5.9000
 doi: 10.21105/joss.03167
 identifiers:
 - type: doi
@@ -73,7 +73,7 @@ references:
     name: R Foundation for Statistical Computing
     address: Vienna, Austria
   year: '2024'
-  version: '>= 4.1.0'
+  version: '>= 4.3.0'
 - type: software
   title: correlation
   abstract: 'correlation: Methods for Correlation Analysis'
@@ -326,7 +326,7 @@ references:
     orcid: https://orcid.org/0000-0002-9271-5075
   year: '2024'
   doi: 10.32614/CRAN.package.insight
-  version: '>= 0.20.5'
+  version: '>= 1.0.0'
 - type: software
   title: paletteer
   abstract: 'paletteer: Comprehensive Collection of Color Palettes'
@@ -371,7 +371,7 @@ references:
     orcid: https://orcid.org/0000-0001-9560-6336
   year: '2024'
   doi: 10.32614/CRAN.package.parameters
-  version: '>= 0.23.0'
+  version: '>= 0.24.0'
 - type: software
   title: patchwork
   abstract: 'patchwork: The Composer of Plots'
@@ -596,6 +596,8 @@ references:
   - family-names: Ripley
     given-names: Brian
     email: [email protected]
+  - family-names: Venables
+    given-names: Bill
   year: '2024'
   doi: 10.32614/CRAN.package.MASS
 - type: software

DESCRIPTION

@@ -40,9 +40,9 @@ Imports:
     ggside (>= 0.3.1),
     ggsignif (>= 0.6.4),
     glue (>= 1.8.0),
-    insight (>= 0.20.5),
+    insight (>= 1.0.0),
     paletteer (>= 1.6.0),
-    parameters (>= 0.23.0),
+    parameters (>= 0.24.0),
     patchwork (>= 1.3.0),
     performance (>= 0.12.4),
     purrr (>= 1.0.2),

R/combine-plots.R

@@ -58,11 +58,12 @@
 #' )
 #' @export
 combine_plots <- function(
-    plotlist,
-    plotgrid.args = list(),
-    annotation.args = list(),
-    guides = "collect",
-    ...) {
+  plotlist,
+  plotgrid.args = list(),
+  annotation.args = list(),
+  guides = "collect",
+  ...
+) {
   exec(patchwork::wrap_plots, !!!plotlist, guides = guides, !!!plotgrid.args) +
     exec(patchwork::plot_annotation, !!!annotation.args)
 }

R/extract-stats.R

@@ -70,7 +70,6 @@ extract_stats <- function(p) {
 }
 
 
-
 # function factory to extract particular kind of stats data
 .extract_stats_data <- function(data_component) {
   function(p) {

R/ggbarstats.R

@@ -39,36 +39,37 @@
 #' extract_stats(p)
 #' @export
 ggbarstats <- function(
-    data,
-    x,
-    y,
-    counts = NULL,
-    type = "parametric",
-    paired = FALSE,
-    results.subtitle = TRUE,
-    label = "percentage",
-    label.args = list(alpha = 1.0, fill = "white"),
-    sample.size.label.args = list(size = 4.0),
-    digits = 2L,
-    proportion.test = results.subtitle,
-    digits.perc = 0L,
-    bf.message = TRUE,
-    ratio = NULL,
-    conf.level = 0.95,
-    sampling.plan = "indepMulti",
-    fixed.margin = "rows",
-    prior.concentration = 1.0,
-    title = NULL,
-    subtitle = NULL,
-    caption = NULL,
-    legend.title = NULL,
-    xlab = NULL,
-    ylab = NULL,
-    ggtheme = ggstatsplot::theme_ggstatsplot(),
-    package = "RColorBrewer",
-    palette = "Dark2",
-    ggplot.component = NULL,
-    ...) {
+  data,
+  x,
+  y,
+  counts = NULL,
+  type = "parametric",
+  paired = FALSE,
+  results.subtitle = TRUE,
+  label = "percentage",
+  label.args = list(alpha = 1.0, fill = "white"),
+  sample.size.label.args = list(size = 4.0),
+  digits = 2L,
+  proportion.test = results.subtitle,
+  digits.perc = 0L,
+  bf.message = TRUE,
+  ratio = NULL,
+  conf.level = 0.95,
+  sampling.plan = "indepMulti",
+  fixed.margin = "rows",
+  prior.concentration = 1.0,
+  title = NULL,
+  subtitle = NULL,
+  caption = NULL,
+  legend.title = NULL,
+  xlab = NULL,
+  ylab = NULL,
+  ggtheme = ggstatsplot::theme_ggstatsplot(),
+  package = "RColorBrewer",
+  palette = "Dark2",
+  ggplot.component = NULL,
+  ...
+) {
   # data frame ------------------------------------------
 
   # make sure both quoted and unquoted arguments are allowed
@@ -221,11 +222,12 @@ ggbarstats <- function(
 #' )
 #' @export
 grouped_ggbarstats <- function(
-    data,
-    ...,
-    grouping.var,
-    plotgrid.args = list(),
-    annotation.args = list()) {
+  data,
+  ...,
+  grouping.var,
+  plotgrid.args = list(),
+  annotation.args = list()
+) {
   .grouped_list(data, {{ grouping.var }}) %>%
     purrr::pmap(.f = ggbarstats, ...) %>%
     combine_plots(plotgrid.args, annotation.args)