-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DurationParser
allowing invalid input
#772
base: master
Are you sure you want to change the base?
Fix DurationParser
allowing invalid input
#772
Conversation
…nually parsing the input
Test Results 88 files ±0 88 suites ±0 12s ⏱️ -1s Results for commit d3911ac. ± Comparison against base commit 3c83f9a. This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
This isn't the case in 2.x, the tree will restore the cursor on a failed parse. You only need to do this if your parsing logic calls for it. |
In that case the docs need updating 👍🏻 I'll revert that change here for now |
Yes, the docs should be updated. When we switched over to the |
DurationParser
using that regex andMatcher#find()
only finds the pattern in the given input string, while the pattern is right for individual segments denoting value-unit sequences, it does not prevent the input to have non-matching content.This patch fixes that by manually parsing the input.
Additionally it conforms to the recommended way of parsing an argument: peek input, pop input on successful parsing.