Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the current http.request to the _update_user backend hook #351

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

devo-devo
Copy link

@devo-devo devo-devo commented Oct 11, 2022

feat: Passes the current request to the _update_user hook.
This should allow developers, especially those dealing with multi-tenant sites, to make updates to the user based on the request context.
Closes #350

@devo-devo
Copy link
Author

devo-devo commented Oct 14, 2022

@peppelinux wondering what you're thinking of this? Not 100% sure what a could test for this would be.

Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have also to add the argument request in the _update_user method, here
https://github.com/IdentityPython/djangosaml2/blob/master/djangosaml2/backends.py#L176

and also, please increase the release number here https://github.com/IdentityPython/djangosaml2/blob/master/setup.py#L30 to 1.5.4

please also change the titple of the PR and add a description about the scope of your contribution and the new feature that it introduce in the project

@devo-devo devo-devo changed the title pass request to_update_user Pass the current http.request to the _update_user backend hook Oct 18, 2022
@devo-devo devo-devo requested a review from peppelinux October 18, 2022 18:36
@devo-devo
Copy link
Author

@peppelinux thank you for your notes! updated.

@peppelinux
Copy link
Member

peppelinux commented Oct 26, 2022

Please devo-devo, can you improve the documentation of djangosaml2, including this additional feature and a short description of your implementation use case and how you did it with the release we're going to make?

@devo-devo
Copy link
Author

Will do asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: multi-tenant site - request during authentication.
2 participants