Use ES6 default parameters instead of deprecated defaultProps property #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Iconscout#86 and Iconscout#64 The work on this PR was sponsored by [SUSI&James GmbH](https://susiandjames.com/)
This was referenced Jul 10, 2024
|
Please merge as soon as possiable |
|
@tarunmangukiya and @rankarpan please review and merge this. Same update to Iconscout/react-unicons-solid would be aprciated. |
htoann
approved these changes
Jul 27, 2024
|
Fair point, @willibix. I'll happily add the same update to https://github.com/Iconscout/react-unicons-solid as well once this change here gets approved and merged (ping @rankarpan). |
|
We need a people who has permission to merge it |
|
i have made another package that implements the same icons with TypeScript and default params |
|
@Tooni amazing! thanks |
|
*ping @rankarpan |
|
Any update? |
Julien-Decoen
approved these changes
Nov 15, 2024
|
Hey @imzedi, any chance this PR gets reviewed and merged? |
|
Yes @fnogatz, Will check them out soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #86 and #64, the current version of the icons results in warnings like the following:
In this PR, we adjust the
build/generate.jsscript which is called onnpm run generate, and newly create the icon components.The work on this PR was sponsored by SUSI&James GmbH.