Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service set member count while on director branch #2940

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raviks789
Copy link
Collaborator

While on director branch the service set member count is always displayed as 1 instead of actual count.

Before:
Screenshot 2024-12-09 at 18 21 25

After:
Screenshot 2024-12-09 at 18 23 53

@cla-bot cla-bot bot added the cla/signed label Dec 9, 2024
@raviks789 raviks789 requested a review from lippserd December 10, 2024 15:32
@raviks789 raviks789 self-assigned this Dec 10, 2024
@raviks789 raviks789 marked this pull request as ready for review December 10, 2024 15:32
@raviks789 raviks789 added this to the v1.11.3 milestone Dec 10, 2024
@lippserd
Copy link
Member

lippserd commented Dec 11, 2024

Do you know why you've introduced the grouping in dcd3687 in the first place?

@raviks789
Copy link
Collaborator Author

Do you know why you've introduced the grouping in dcd3687 in the first place?

I don't exactly remember. But I think it was retained after I had introduced it to test the queries for this change.

@raviks789 raviks789 force-pushed the fix/service-set-member-count-on-branch branch from 58a2ab3 to 1f7015d Compare December 11, 2024 09:59
@raviks789 raviks789 removed this from the v1.11.3 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants