Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckTimeSync: Let "IgnoreService" truly ignore the local service #422

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RincewindsHat
Copy link
Member

Previously the "-IgnoreService" flag did only prevent the specific IcingaCheck from becoming CRITICAL (which does not prevent it from becoming UNKNOWN!).
This does not really fit the definition of "ignore" in my book.

This commit changes the behaviour to completely ignore it, when the flag is set.

Copy link

cla-bot bot commented Oct 21, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lorenz Kästle.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@RincewindsHat RincewindsHat force-pushed the fix/CheckTimeSync_IgnoreService branch from 82af87e to 2a1e5f3 Compare October 21, 2024 09:51
@cla-bot cla-bot bot added the cla/signed label Oct 21, 2024
@Lprod
Copy link

Lprod commented Oct 23, 2024

We have tested the solution in our company and the result meets the expectations of the “IgnoreService” function. A quick implementation and release would be nice from our point of view.
Thank you very much

@RincewindsHat RincewindsHat requested a review from Crited November 5, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants