Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test types.Name() #28

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Test types.Name() #28

merged 1 commit into from
Jul 25, 2024

Conversation

Al2Klimov
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jul 5, 2024
@Al2Klimov Al2Klimov added the enhancement New feature or request label Jul 5, 2024
@oxzi oxzi added the tests Adding tests to existing code label Jul 19, 2024
@Al2Klimov Al2Klimov removed the enhancement New feature or request label Jul 19, 2024
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

However, I was not able to find any usage, neither in the icinga-go-library nor in icingadb, icinga-notifications or icinga-kubernetes. Thus, I am unsure what it is expected to receive.

@yhabteab
Copy link
Member

yhabteab commented Jul 25, 2024

However, I was not able to find any usage, neither in the icinga-go-library nor in icingadb, icinga-notifications or icinga-kubernetes. Thus, I am unsure what it is expected to receive.

See utils#TableName().

func TableName(t interface{}) string {
if tn, ok := t.(TableNamer); ok {
return tn.TableName()
} else {
return strcase.Snake(types.Name(t))

@oxzi
Copy link
Member

oxzi commented Jul 25, 2024

Thanks @yhabteab. Somehow my IDE decided it does not exists, while grepping found plenty :/

@julianbrost julianbrost merged commit 7869494 into main Jul 25, 2024
2 checks passed
@julianbrost julianbrost deleted the test-Name branch July 25, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR tests Adding tests to existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants